Skip to content

fix: IO type reappears when card is added#16398

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
Haz3-jolt:my-feature-branch-3
May 14, 2024
Merged

fix: IO type reappears when card is added#16398
BrayanDSO merged 1 commit intoankidroid:mainfrom
Haz3-jolt:my-feature-branch-3

Conversation

@Haz3-jolt
Copy link
Copy Markdown
Member

@Haz3-jolt Haz3-jolt commented May 14, 2024

Purpose / Description

Removed code from NoteEditor which was causing #16389 and also removed its fun from Collection.kt

Fixes

Approach

How Has This Been Tested?

Compiles and builds, and bug squashed.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison changed the title fixes #16389 IO type reappears when card is added. fix: IO type reappears when card is added May 14, 2024
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label May 14, 2024
@BrayanDSO BrayanDSO added this pull request to the merge queue May 14, 2024
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 14, 2024
Merged via the queue into ankidroid:main with commit f336065 May 14, 2024
@github-actions github-actions bot added this to the 2.19 release milestone May 14, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 14, 2024
@Haz3-jolt Haz3-jolt deleted the my-feature-branch-3 branch May 24, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: image occlusion type reappears when a card is added

3 participants